Skip to content

terraform: fix GCP SQL db instance deletion #35717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbyiliev merged 2 commits into from
Mar 28, 2026
+2 −1
Merged

terraform: fix GCP SQL db instance deletion #35717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc0d4b
terraform: fix GCP SQL db instance deletion
bobbyiliev Mar 27, 2026
4da723f
ci: re-enable GCP Terraform E2E nightly test
bobbyiliev Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/nightly/pipeline.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,6 @@ steps:
# Cleanup runs in pre-exit hook
args: [--no-cleanup]
ci-builder: stable
skip: "Flaky because of materialize-terraform-self-managed#157"
branches: "main v*.* *gcp* *tf* *terraform* *helm* *self-managed* *orchestratord*"

- id: terraform-azure
Expand Down
2 changes: 2 additions & 0 deletions test/terraform/gcp-temporary/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ module "database" {

tier = local.database_config.tier

random_instance_name = true

labels = var.labels
}

Expand Down
Loading