terraform: fix GCP SQL db instance deletion#35717
Merged
bobbyiliev merged 2 commits intoMaterializeInc:mainfrom Mar 28, 2026
Merged
terraform: fix GCP SQL db instance deletion#35717bobbyiliev merged 2 commits intoMaterializeInc:mainfrom
bobbyiliev merged 2 commits intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
def-
reviewed
Mar 27, 2026
Contributor
def-
left a comment
There was a problem hiding this comment.
Can you also reenable the test in ci/nightly/pipeline.template.yml by removing the skip?
Contributor
Author
ah yes, good point! |
def-
approved these changes
Mar 28, 2026
Contributor
|
Needs a rebase for the postgres-cdc issue, it's fixed on main. |
e31dd32 to
4da723f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per: MaterializeInc/materialize-terraform-self-managed#178