Skip to content

terraform: fix GCP SQL db instance deletion#35717

Merged
bobbyiliev merged 2 commits intoMaterializeInc:mainfrom
bobbyiliev:terraform-use-random-instance-name
Mar 28, 2026
Merged

terraform: fix GCP SQL db instance deletion#35717
bobbyiliev merged 2 commits intoMaterializeInc:mainfrom
bobbyiliev:terraform-use-random-instance-name

Conversation

@bobbyiliev
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@bobbyiliev bobbyiliev requested a review from def- March 27, 2026 05:40
@bobbyiliev bobbyiliev enabled auto-merge (squash) March 27, 2026 07:43
Copy link
Copy Markdown
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also reenable the test in ci/nightly/pipeline.template.yml by removing the skip?

@bobbyiliev bobbyiliev requested a review from a team as a code owner March 28, 2026 07:56
@bobbyiliev bobbyiliev requested a review from def- March 28, 2026 07:56
@bobbyiliev
Copy link
Copy Markdown
Contributor Author

Can you also reenable the test in ci/nightly/pipeline.template.yml by removing the skip?

ah yes, good point!

@def-
Copy link
Copy Markdown
Contributor

def- commented Mar 28, 2026

Needs a rebase for the postgres-cdc issue, it's fixed on main.

@bobbyiliev bobbyiliev force-pushed the terraform-use-random-instance-name branch from e31dd32 to 4da723f Compare March 28, 2026 08:36
@bobbyiliev bobbyiliev merged commit 2f5f40d into MaterializeInc:main Mar 28, 2026
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants