Skip to content

bugfix(htree): Handle null parent pivots and correct animation data indexing#444

Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/htree-null-parent-animation-indexing
Open

bugfix(htree): Handle null parent pivots and correct animation data indexing#444
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/htree-null-parent-animation-indexing

Conversation

@seer-by-sentry
Copy link
Copy Markdown

@seer-by-sentry seer-by-sentry bot commented Apr 1, 2026

Fixes CLIENT-3DA. The issue was that: HTree's animation update iterates beyond allocated NodeMotion array, corrupting memory, leading to Matrix3D::Multiply access violation.

  • Removed assert(pivot->Parent != nullptr) to prevent crashes when a pivot's parent is null.
  • Added a check to skip processing pivots with null parents, preventing dereferencing issues.
  • Adjusted nodeMotion increment logic to only advance when a pivot has animation data, ensuring correct indexing.
  • Conditionally increments nodeMotion for null-parented pivots if they are within the animated pivot range.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 12700695

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants