Skip to content

bugfix(object): Prevent null pointer dereference in onCollide after object destruction #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix(object): Prevent null pointer dereference in onCollide after object destruction #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2168,6 +2168,15 @@ void Object::onCollide( Object *other, const Coord3D *loc, const Coord3D *normal
#endif
break;
}

// If this object or the other object has been destroyed by a previous
// collide module handler, stop processing further modules to avoid
// accessing freed/invalid memory (null pointer dereference).
if( isDestroyed() )
break;
if( other != nullptr && other->isDestroyed() )
break;

#ifdef DEBUG_CRC
//DEBUG_LOG(("Object::onCollide() - calling collide module"));
#endif
Expand Down
9 changes: 9 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,6 +2445,15 @@ void Object::onCollide( Object *other, const Coord3D *loc, const Coord3D *normal
#endif
break;
}

// If this object or the other object has been destroyed by a previous
// collide module handler, stop processing further modules to avoid
// accessing freed/invalid memory (null pointer dereference).
if( isDestroyed() )
break;
if( other != nullptr && other->isDestroyed() )
break;

#ifdef DEBUG_CRC
//DEBUG_LOG(("Object::onCollide() - calling collide module"));
#endif
Expand Down
Loading