Skip to content

bugfix(AI): Re-validate target before firing to prevent attacking dead units #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

bugfix(AI): Re-validate target before firing to prevent attacking dead units #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5096,6 +5096,10 @@ StateReturnType AIAttackFireWeaponState::update()

if (m_att->isAttackingObject())
{
// Re-validate victim immediately before firing; it may have been destroyed since the earlier check.
if (!victim || victim->isEffectivelyDead())
return STATE_FAILURE;

obj->fireCurrentWeapon(victim);
// clear this, just in case.
obj->clearStatus( MAKE_OBJECT_STATUS_MASK( OBJECT_STATUS_IGNORING_STEALTH ) );
Expand Down
3 changes: 3 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5256,6 +5256,9 @@ StateReturnType AIAttackFireWeaponState::update()
// If the concept of linked turrets is further developed then God help you, and put more code right here
// that lookl like the //LINKED TURRETS// block, below

// Re-validate victim immediately before firing; it may have been destroyed since the earlier check.
if (!victim || victim->isEffectivelyDead())
return STATE_FAILURE;

obj->fireCurrentWeapon(victim);

Expand Down
Loading