Skip to content

Fix TurretAI crash during state machine destruction #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TurretAI crash during state machine destruction #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,13 @@ TurretAI::~TurretAI()
stopRotOrPitchSound();

if (m_turretStateMachine)
{
// TheSuperHackers @bugfix xezon 2025 Halt the state machine before deleting it to prevent
// StateMachine::~StateMachine() from calling onExit() on the current state, which may
// access the owning object's AI interface (already nulled in Object::~Object()) and crash.
m_turretStateMachine->halt();
deleteInstance(m_turretStateMachine);
}
}

// ------------------------------------------------------------------------------------------------
Expand Down
6 changes: 6 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,13 @@ TurretAI::~TurretAI()
stopRotOrPitchSound();

if (m_turretStateMachine)
{
// TheSuperHackers @bugfix xezon 2025 Halt the state machine before deleting it to prevent
// StateMachine::~StateMachine() from calling onExit() on the current state, which may
// access the owning object's AI interface (already nulled in Object::~Object()) and crash.
m_turretStateMachine->halt();
deleteInstance(m_turretStateMachine);
}
}

// ------------------------------------------------------------------------------------------------
Expand Down
Loading