Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
============================================
+ Coverage 18.36% 23.89% +5.52%
- Complexity 657 758 +101
============================================
Files 78 84 +6
Lines 3496 3817 +321
============================================
+ Hits 642 912 +270
- Misses 2854 2905 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WarLikeLaux
force-pushed
the
feature/request-context-panel
branch
from
8b918b9 to
0060891
Compare
Also make behavior class values copyable and clean up PHPStan baseline.
Replace direct Yii::$app access with getWebApplication() helper, add PHPStan type aliases, extract buildActionInfo() method, and use requestedParams instead of query params for route parameters.
Use getWebApplication() helper, fix event listener cleanup, add tests for standalone action and missing action method cases, and include 'file' key in groupNodes test data.
WarLikeLaux
force-pushed
the
feature/request-context-panel
branch
from
44aa581 to
e06256b
Compare
- Replace FQCN with use-imports for Reflection classes - Remove redundant getApplication()/getWebApplication() wrappers, use Yii::$app directly as in other panels - Pass controller/action as parameters to resolve methods instead of re-fetching from Yii::$app in each method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
RequestContextPanel- a new debug panel that shows request context: route, controller/action with line number, layout, rendered views tree, controller behaviors, and route parameters.Features
Coverage
58 tests.
Request-context classes coverage:
RequestContextPanel: 102/113 lines (90.27%), 14/19 methodsRequestContextTextFormatter: 37/38 lines (97.37%), 2/3 methodsRequestContextTreeFormatter: 54/55 lines (98.18%), 6/7 methodsRequestContextValueRenderer: 14/14 lines (100.00%), 2/2 methodsCombined for request-context classes: 207/220 lines (94.09%), 24/31 methods (77.42%).
Uncovered:
getSummary()/getDetail()(require full Yii module view context),catch (ReflectionException)branches (unreachable in normal conditions), malformed-node skip path in tree grouping, and a few panel wiring branches around formatter lazy initialization.