Skip to content

Feature/yangkit complete validation#38

Merged
lllyfeng merged 7 commits intoyang-central:mainfrom
network-analytics:feature/yangkit-complete-validation
Apr 15, 2026
Merged

Feature/yangkit complete validation#38
lllyfeng merged 7 commits intoyang-central:mainfrom
network-analytics:feature/yangkit-complete-validation

Conversation

@ahuangfeng
Copy link
Copy Markdown
Contributor

  • Update antl4-runtime to 4.11.1
  • force Java 11
  • Allow not mandatory root schemas to not be present in the encoded message.
  • Allow augmentation of mandatory nodes without "when" statements within the same module (errata; Andy reported that it should allowed when it is within the same module)
  • Allow messages without the wrapper "data".
  • Example of parsing ietf-interfaces.yang

@ahuangfeng ahuangfeng marked this pull request as ready for review May 24, 2025 11:11
@lllyfeng
Copy link
Copy Markdown
Contributor

why force java 11? java 8 is the most popular.

@lllyfeng
Copy link
Copy Markdown
Contributor

and I cannot merge this PR for some conflicts are not resolved.

@ahuangfeng
Copy link
Copy Markdown
Contributor Author

and I cannot merge this PR for some conflicts are not resolved.

This PR #38 is to be merged after main branch is fixed (currently main is not compiling). We will rebase and fix the conflict when main is working again.

Regarding forcing java 11, I can rollback if needed

@lllyfeng
Copy link
Copy Markdown
Contributor

lllyfeng commented Jul 1, 2025

and I cannot merge this PR for some conflicts are not resolved.

This PR #38 is to be merged after main branch is fixed (currently main is not compiling). We will rebase and fix the conflict when main is working again.

Regarding forcing java 11, I can rollback if needed

hi, I have published a new version,1.5.0, and the main branch has been fixed.


if (!result.isOk()) {
for (ValidatorRecord<?, ?> record : result.getRecords()) {
System.out.println("Error: "+ record.getBadElement() + ':' + record.getErrorMsg().getMessage());
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for those printed info, how about using record.getSeverity() instead of all as Error?

(so that other severities such as Warning etc. can be distinguished from here)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only ‘Error’ means result is not ok,:)

@ahuangfeng ahuangfeng force-pushed the feature/yangkit-complete-validation branch from b025a6e to 42ea5f8 Compare March 25, 2026 10:12
@ahuangfeng ahuangfeng force-pushed the feature/yangkit-complete-validation branch from 42ea5f8 to 3cf30a4 Compare April 13, 2026 13:36
@ahuangfeng ahuangfeng force-pushed the feature/yangkit-complete-validation branch from 3cf30a4 to e1b2642 Compare April 15, 2026 09:49
@ahuangfeng ahuangfeng force-pushed the feature/yangkit-complete-validation branch from e1b2642 to 3172f74 Compare April 15, 2026 10:53
@ahuangfeng ahuangfeng force-pushed the feature/yangkit-complete-validation branch from 3172f74 to 87e301c Compare April 15, 2026 14:49
@ahuangfeng
Copy link
Copy Markdown
Contributor Author

Dear @lllyfeng ,
I updated the code and tested on my local validating ietf-interfaces.yang and ietf-telemetry-message.yang messages.
The CI has been updated to Java 11. The current maven project does not force any java version, so users can still use any version they want. However, antlr4-runtime needed to be updated to enable integration with the Kafka project.
Regards,
Alex

@lllyfeng lllyfeng merged commit 36c64ca into yang-central:main Apr 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants