Draft
Conversation
the latest version of hops dropped node js support in the engines field. this test runs also on 14.x and 13.x branches, which still have node 12 and 15 in their test matrix. if they refer to latest, instead of their own version the test fails as hosp 15 does not support those node versions any more.
Transitive dependencies (namely `@npmcli/fs`) dropped support for Node.js v15, which means Hops can't be used with Hops 15 anymore. We could potentially downgrade the `terser-webpack-plugin`, but we decided against that, because we don't want to remove features in Hops just because it stopped working with an unmaintained non-lts version. Co-authored-by: Markus Wolf <markus.wolf@new-work.se> Co-authored-by: Philipp Hinrichsen <philipp.hinrichsen@new-work.se>
To get around the colors dependency in prompt
For some reason we see intermittent failures with the source-map-support package (examples: evanw/node-source-map-support#252 and evanw/node-source-map-support#93). The fix that worked for us seems to be to externalize the source-map. Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next v14.x release
Changes:
Remove colors (#2013) ❌