Draft
Conversation
The dev command incorrectly required `entrypoint()` (which only reads from [custom].entrypoint) for Ruffle and JsDos engines. This caused "Engine config requires an entrypoint" errors for valid Ruffle/JsDos configs. Now mirrors the build push logic: Custom uses entrypoint(), Ruffle/JsDos use executable_entrypoint_params(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wavedash devfailed with "Engine config requires an entrypoint" for Ruffle and JsDos projectsentrypoint()for all three engine types (Custom, JsDos, Ruffle), butentrypoint()only reads from[custom].entrypointentrypoint()for Custom engines; for Ruffle/JsDos, passexecutable_entrypoint_params()instead — matching the existingbuild pushlogicTest plan
wavedash devfrom a project with a[ruffle]config — should launch dev server without errorwavedash devfrom a project with a[jsdos]config — should work similarlywavedash devfrom a project with a[custom]config — should still require entrypoint as before🤖 Generated with Claude Code