Windows: improve PowerShell support

[swissspidy]

Just basic REPL functionality for now.

[github-actions]

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

• composer install: Install dependencies.
• composer test: Run the full test suite.
• composer phpcs: Check for code style violations.
• composer phpcbf: Automatically fix code style violations.
• composer phpunit: Run unit tests.
• composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

[gemini-code-assist]

Code Review

This pull request introduces Windows support for the WP-CLI shell by utilizing powershell.exe and Read-Host. Feedback highlights a lack of command history support in the new PowerShell implementation, which is a regression compared to other shells. Additionally, the removal of the shell binary validation check for non-PowerShell environments should be restored to ensure proper error handling for custom shell configurations.

[gemini-code-assist]

The new PowerShell implementation provides basic REPL functionality, but it's missing command history support, which is a crucial feature for an interactive shell. The use of Read-Host with the -NoProfile switch on powershell.exe prevents the use of PSReadLine for history. This is a significant usability regression compared to the bash/ksh implementation which explicitly handles a history file.

Please consider implementing history support for PowerShell. This could involve:

• Manually managing a history file with PowerShell commands (e.g., Get-Content/Add-Content).
• Interacting with the PSReadLine module's history functions if it's available.

Without history, the shell is much less productive.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/WP_CLI/Shell/REPL.php	50.00%	13 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR improves the built-in wp shell --basic REPL behavior on Windows by adding a PowerShell-based prompt path and adjusting feature tests to avoid POSIX-only /dev/null redirection.

Changes:

• Add Windows-specific prompt handling (PowerShell command path + non-TTY STDIN reading) in the REPL.
• Normalize line-ending trimming to handle CRLF (\r\n) correctly.
• Update Behat feature scenarios to use an empty input file instead of /dev/null, and skip a custom-shell-path scenario on Windows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/WP_CLI/Shell/REPL.php	Adds Windows/PowerShell prompt support and a TTY-detection helper; adjusts line-ending handling.
features/shell.feature	Makes shell feature tests more cross-platform by avoiding /dev/null and adding Windows skips/flags where needed.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[swissspidy]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Done in a1c89c5. The two issues from the review are now addressed:

1. PowerShell detection now uses strtolower(basename($shell_binary)) compared against ['powershell.exe', 'pwsh.exe'], so full paths (e.g. C:\...\powershell.exe) and pwsh.exe are handled correctly regardless of casing.
2. The returned command string now uses escapeshellarg($shell_binary) instead of a hard-coded powershell.exe, so custom paths (including those with spaces) work correctly.