Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…ands Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for default shell ksh under OpenBSD
Add ksh support for OpenBSD (and mksh/pdksh)
Mar 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ksh compatibility to the built-in wp shell --basic REPL so it can run on OpenBSD (and similar environments) where /bin/ksh is the default and bash-specific read/history builtins are unavailable.
Changes:
- Add ksh-family shell detection (
is_ksh_shell()) and a combinedis_supported_shell()helper. - Expand
$SHELLfallback to accept supported shells (bash or ksh-family) instead of bash-only. - Introduce a ksh-specific prompt command path using POSIX
readand printing the prompt to stderr (skipping history).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp shellfails immediately on OpenBSD because the REPL's prompt command uses bash-specific builtins (read -e,read -p,history -r/-s/-w) that ksh does not support.Changes
is_ksh_shell()— detects ksh-compatible shells by binary basename (ksh,ksh93,ksh88,mksh,pdksh)is_supported_shell()— helper combining bash + ksh checks; used by the$SHELLenv-var fallback so OpenBSD users withSHELL=/bin/kshno longer need to setWP_CLI_CUSTOM_SHELLcreate_prompt_cmd()— when a ksh shell is detected, replaces bash-specific flags with POSIX equivalents; history is skipped (unavailable in non-interactive ksh mode):The prompt is written to stderr so it remains visible to the user without being captured by
popen.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.