Skip to content

feat!: remove search param from listResources #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atainter wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −16
Open

feat!: remove search param from listResources #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/authorization/authorization.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,19 +1265,6 @@ describe('Authorization', () => {
});
});

it('passes search filter', async () => {
fetchOnce(listResourcesFixture);

await workos.authorization.listResources({
search: 'Budget',
});

expect(fetchSearchParams()).toEqual({
search: 'Budget',
order: 'desc',
});
});

it('defaults to desc order when order is not specified', async () => {
fetchOnce(listResourcesFixture);

Expand Down
2 changes: 0 additions & 2 deletions src/authorization/interfaces/list-authorization-resources-options.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export interface ListAuthorizationResourcesOptions extends PaginationOptions {
parentResourceId?: string;
parentResourceTypeSlug?: string;
parentExternalId?: string;
search?: string;
}

export interface SerializedListAuthorizationResourcesOptions extends PaginationOptions {
Expand All @@ -15,5 +14,4 @@ export interface SerializedListAuthorizationResourcesOptions extends PaginationO
parent_resource_id?: string;
parent_resource_type_slug?: string;
parent_external_id?: string;
search?: string;
}
1 change: 0 additions & 1 deletion src/authorization/serializers/list-authorization-resources-options.serializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@ export const serializeListAuthorizationResourcesOptions = (
...(options.parentExternalId && {
parent_external_id: options.parentExternalId,
}),
...(options.search && { search: options.search }),
...serializePaginationOptions(options),
});
Loading