port/cavium: fix Octeon AES-GCM AAD GHASH bug#10439
Open
ejohnstown wants to merge 1 commit intowolfSSL:masterfrom
Open
port/cavium: fix Octeon AES-GCM AAD GHASH bug#10439ejohnstown wants to merge 1 commit intowolfSSL:masterfrom
ejohnstown wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Octeon_AesGcm_SetAAD unconditionally ran XOR0/XORMUL1 on the partial-block buffer after the main loop, which processed an extra all-zero block when aadSz was a non-zero multiple of 16, corrupting the GCM tag. Guard the trailing XOR/MUL with `if (remainder > 0)`. Issue: F-3335
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Octeon AES-GCM GHASH correctness issue in the Cavium sync port where AAD processing incorrectly incorporated an extra all-zero block when aadSz was a non-zero multiple of 16, corrupting the resulting authentication tag.
Changes:
- Guard the trailing partial-block GHASH XOR/MUL step in
Octeon_AesGcm_SetAAD()so it only runs whenremainder > 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Octeon_AesGcm_SetAAD unconditionally ran XOR0/XORMUL1 on the partial-block buffer after the main loop, which processed an extra all-zero block when aadSz was a non-zero multiple of 16, corrupting the GCM tag. Guard the trailing XOR/MUL with
if (remainder > 0).Issue: F-3335
Testing
Visual inspection.
Checklist