esp: macro cleanup, and fix some data type sizes.#66
Merged
danielinux merged 1 commit intowolfSSL:masterfrom Mar 4, 2026
Merged
esp: macro cleanup, and fix some data type sizes.#66danielinux merged 1 commit intowolfSSL:masterfrom
danielinux merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up internal ESP helper macros and fixes length-related type sizing in the ESP encryption/decryption routines, aligning length calculations with the uint32_t frame lengths used throughout the ESP unwrap/wrap flow.
Changes:
- Wrap ESP length/pointer macros in full parentheses to avoid precedence surprises in macro expansions.
- Remove the unused
iv_lenparameter fromesp_enc_iv()and update all local call sites. - Widen
enc_len(and RFC4543aad_len) fromuint16_ttouint32_tto prevent truncation for larger ESP payloads.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielinux
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enc_lentouint32_tsince its input is ultimately fromuint32_tframe_len.Fixes: F-327, F-328, F-333.