Skip to content

esp: macro cleanup, and fix some data type sizes.#66

Merged
danielinux merged 1 commit intowolfSSL:masterfrom
philljj:f_misc_fixes
Mar 4, 2026
Merged

esp: macro cleanup, and fix some data type sizes.#66
danielinux merged 1 commit intowolfSSL:masterfrom
philljj:f_misc_fixes

Conversation

@philljj
Copy link
Contributor

@philljj philljj commented Mar 4, 2026

Description

  • esp macro cleanup (wrap parentheses, remove unused parm).
  • widen enc_len to uint32_t since its input is ultimately from uint32_t frame_len.

Fixes: F-327, F-328, F-333.

@philljj philljj self-assigned this Mar 4, 2026
Copilot AI review requested due to automatic review settings March 4, 2026 16:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up internal ESP helper macros and fixes length-related type sizing in the ESP encryption/decryption routines, aligning length calculations with the uint32_t frame lengths used throughout the ESP unwrap/wrap flow.

Changes:

  • Wrap ESP length/pointer macros in full parentheses to avoid precedence surprises in macro expansions.
  • Remove the unused iv_len parameter from esp_enc_iv() and update all local call sites.
  • Widen enc_len (and RFC4543 aad_len) from uint16_t to uint32_t to prevent truncation for larger ESP payloads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielinux danielinux merged commit 75e4774 into wolfSSL:master Mar 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants