Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TC3 HAL self-update functionality by ensuring relevant HAL functions are marked as RAMFUNCTION (required when executing code during flash self-update) and by correcting the ARCH_FLASH_OFFSET values to be target-specific (HSM vs Tricore) rather than a single zero offset.
Changes:
- Several HAL functions in
hal/aurix_tc3xx.care marked withRAMFUNCTION ARCH_FLASH_OFFSETis removed from a shared location and assigned distinct values per build target (HSM vs Tricore)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hal/aurix_tc3xx.c | Adds RAMFUNCTION to arch_reboot, hal_flash_unlock, hal_flash_lock, ext_flash_write, ext_flash_erase, ext_flash_lock, and ext_flash_unlock |
| arch.mk | Moves ARCH_FLASH_OFFSET from shared aurix_tc3xx scope to HSM and Tricore-specific branches with distinct values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes for TC3 HAL when testing some self-update permutations:
RAMFUNCTIONARCH_FLASH_OFFSET