Conversation
Addresses reviewer feedback by documenting scope decisions for all 6 capabilities from Issue #1966, manifest schema extensions (requires, replaces, suggests), dependency graph algorithm, and lazy loading strategy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- ModuleGraph.cfc: dependency resolution with topological sort (Kahn's algorithm), cycle detection, replacement handling, and suggest ordering - PackageLoader.cfc: refactored into manifest discovery -> graph resolution -> ordered loading pipeline. Adds lazy loading for packages with lazy:true and no mixins/middleware. New getters: getExcludedPackages(), getLoadOrder(), getPackage(), isPackageLoaded() - SemVer.cfc: add wildcard "*" constraint support - Manifest schema extended with requires, replaces, suggests fields Addresses Issue #1966 capabilities: dependency declarations, compiled dependency graph, and lazy loading. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- ModuleGraphSpec.cfc: tests for topological sort, cycle detection, replacement, missing dependencies, version constraints, suggests - PackageLoaderSpec.cfc: extended with dependency ordering, replacement, cycle detection, missing requirements, lazy loading tests - semverSpec.cfc: add wildcard "*" constraint tests - New test fixtures: depA, depB (ordering), cycleA/cycleB (cycles), replacer (replacement), suggestpkg (soft deps), lazypkg, missingreq Lucee 6: 2303 pass, 0 fail, 0 error Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
docs
enhancement
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Wheels 4.0 module system with dependency declarations, compiled dependency graph, and lazy loading (Issue #1966).
What's included
requires,replaces,suggestsfields inpackage.jsonmanifestsModuleGraph.cfc): Kahn's algorithm topological sort, cycle detection, version constraint validation via SemVerlazy: truein manifest — defers instantiation until first accessreplacesto substitute for another packageKey design decisions
package.jsonoverbox.json: Three packages already use it, and Wheels is moving toward engine-independence from CommandBoxmixins: "none"and no middleware (mixin collection requires eager CFC instantiation)Deferred to follow-up tasks
wheels module:search,module:install,module:create) — requires CommandBox/LuCLI integrationFiles changed
vendor/wheels/ModuleGraph.cfc— New: dependency graph building, topological sort, cycle detectionvendor/wheels/PackageLoader.cfc— Refactored: manifest scan → graph resolution → ordered loadingvendor/wheels/SemVer.cfc— Extended: wildcard*constraint supportvendor/wheels/tests/specs/ModuleGraphSpec.cfc— New: 12 tests for graph resolutionvendor/wheels/tests/specs/PackageLoaderSpec.cfc— Extended: dependency ordering, replacement, lazy loading testsvendor/wheels/tests/specs/semverSpec.cfc— Extended: wildcard*testsvendor/wheels/tests/_assets/packages/(8 fixture packages)docs/superpowers/specs/2026-04-03-module-system-design.md— Design specTest plan
Closes #1966
🤖 Generated with Claude Code