Allow same devServer port with unique publicPath#4701
Open
MITHRAN-BALACHANDER wants to merge 2 commits intowebpack:mainfrom
Open
Allow same devServer port with unique publicPath#4701MITHRAN-BALACHANDER wants to merge 2 commits intowebpack:mainfrom
MITHRAN-BALACHANDER wants to merge 2 commits intowebpack:mainfrom
Conversation
Permit multiple devServer configs to share the same port when each config exposes a unique devMiddleware.publicPath or output.publicPath. Introduces usedPublicPathsByPort tracking and refines the error message to instruct using unique publicPath values for shared ports. Adds a test config (same-ports-dev-server-unique-public-paths.config.js), a test case and snapshot updates to cover the new behavior, and adds webpack-cli to package.json dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(serve): allow shared devServer port when publicPath values are unique
Summary
This PR fixes a serve regression in multi-compiler mode where webpack-cli rejected any repeated devServer port, even when each compiler exposed a different app path.
The serve startup logic now allows multiple devServer configs to share the same port only when each config has a unique public path (resolved from
devServer.devMiddleware.publicPathoroutput.publicPath). If the same port is reused without a unique path, webpack-cli still throws an error.Changes included:
usedPublicPathsByPort.same-ports-dev-server-unique-public-paths.config.js.Motivation:
/login/and/admin/). This PR restores that valid workflow.What kind of change does this PR introduce?
fix + test
Did you add tests for your changes?
Yes.
Added/updated tests cover:
Snapshots were updated accordingly.
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No docs updates are required. This aligns runtime behavior with expected webpack-dev-server multi-compiler usage patterns.
Use of AI
AI assistance was used to help draft and iterate on the implementation and tests. All AI-suggested changes were manually reviewed, edited, and validated with linting and test runs before submission.