Skip to content

fix(cc-widgets): Widget station login issues#638

Open
zachraymer wants to merge 7 commits intowebex:nextfrom
zachraymer:next
Open

fix(cc-widgets): Widget station login issues#638
zachraymer wants to merge 7 commits intowebex:nextfrom
zachraymer:next

Conversation

@zachraymer
Copy link
Contributor

@zachraymer zachraymer commented Mar 3, 2026

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7303

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >
Dial number only accepts US numbers. Needs to accept international numbers as well.
Form validation was not disabling the save/signin button when fields were empty.

by making the following changes

Dial number regex has been changed to include international numbers so we can support prodeu rollout
Disabled attribute on save button has logic to validate empty fields
< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    Testing was done with unit test scenarios as well as manual validation. Dial numbers other than US were entered and passed validation with + character optional. Dial numbers without country codes are not valid still. Empty fields such as missing team and missing dial number do not allow the save and sign in button to be enabled until they are completed.

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@zachraymer zachraymer requested a review from a team as a code owner March 3, 2026 18:36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7009c82571

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-638.d1b38q61t1z947.amplifyapp.com

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6dfb003fc2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@akulakum akulakum added the validated Indicates that the PR is ready for actions label Mar 5, 2026
@zachraymer zachraymer changed the title CAI-7303: Widget station login issues fix(cc-widgets: Widget station login issues Mar 5, 2026
@zachraymer zachraymer changed the title fix(cc-widgets: Widget station login issues fix(cc-widgets): Widget station login issues Mar 5, 2026
@rsarika rsarika added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Mar 5, 2026
@zachraymer
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants