Add a VortexSession for scalar value deserialization#6772
Merged
connortsui20 merged 2 commits intodevelopfrom Mar 3, 2026
Merged
Add a VortexSession for scalar value deserialization#6772connortsui20 merged 2 commits intodevelopfrom
VortexSession for scalar value deserialization#6772connortsui20 merged 2 commits intodevelopfrom
Conversation
connortsui20
changed the title
VortexSession for scalar value deserialization
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/scalar-session
branch
from
8ec17f1 to
fa0282e
Compare
gatesn
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking Issue: #6771
Adds a
VortexSessionparameter to the scalar value deserialization functions, and updates all callers to pass a session.We want this in order to support adding an
Arrayvariant to theScalarValueenum. That is coming in a followup PR (draft is at #6717). This PR just makes it easier to review what is going on.API Changes
Adds a
VortexSessionparameter in a few places.Testing
This changes doesn't actually make use of the session yet, so there is no logical changes (yet).