Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will improve performance by 22.76%
Performance Changes
Comparing Footnotes
|
| AllOr::None => Ok(false), | ||
| AllOr::All => match_each_decimal_value_type!(d.values_type(), |T| { | ||
| for &v in d.buffer::<T>().iter() { | ||
| match acc.checked_add(&DecimalValue::from(v)) { |
There was a problem hiding this comment.
We shouldn't be forcing upcasting here. Just because you have Decimal it doesn't mean you should do all compute in i256 space

First PR implementing the Aggregate Functions proposal in vortex-data/rfcs#21