Skip to content

chore: use matchDepNames for vite-task crates in renovate config#1217

Merged
graphite-app[bot] merged 1 commit intomainfrom
fix-renovate
Apr 2, 2026
Merged

chore: use matchDepNames for vite-task crates in renovate config#1217
graphite-app[bot] merged 1 commit intomainfrom
fix-renovate

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 30, 2026

matchPackageNames matches against the git URL for Cargo git
dependencies, not the crate name. This caused the disable rule to
have no effect, resulting in unwanted update PRs.

Closes #1208
Closes #1203

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026 •
edited
Loading

✅ Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 695dabe
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69ce25c0ed8290000846af06

@fengmk2 Graphite App
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 30, 2026

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 requested review from Boshen and branchseer March 30, 2026 14:15
@fengmk2 fengmk2 self-assigned this Mar 30, 2026
@fengmk2 fengmk2 marked this pull request as ready for review March 30, 2026 14:15
This was referenced Mar 30, 2026
Closed
Closed
Closed
Closed
Closed
Closed
@fengmk2 fengmk2 changed the title fix: use matchDepNames for vite-task crates in renovate config chore: use matchDepNames for vite-task crates in renovate config Mar 31, 2026
@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 2, 2026

@branchseer please take a look

@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 2, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector bot commented Apr 2, 2026

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Apr 2, 2026 •
edited
Loading

Merge activity

@fengmk2
chore: use matchDepNames for vite-task crates in renovate config (#…
695dabe 
…1217)

`matchPackageNames` matches against the git URL for Cargo git
dependencies, not the crate name. This caused the disable rule to
have no effect, resulting in unwanted update PRs.

Closes #1208
Closes #1203
@graphite-app graphite-app bot merged commit 695dabe into main Apr 2, 2026
33 checks passed
@graphite-app graphite-app bot deleted the fix-renovate branch April 2, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branchseer branchseer branchseer approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@fengmk2 fengmk2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fengmk2 @branchseer