Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
ubugeeei
force-pushed
the
feat/publish-support
branch
from
9ed0f44 to
e5e927a
Compare
ubugeeei
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c43ffa0b44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
crates/vite_global_cli/src/commands/release/templates/publish.yml
Outdated
Show resolved
Hide resolved
|
NOTE: I temporarily removed the Draft status to try triggering a review with Codex, but it is still a draft. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3c9209675
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…lus into feat/publish-support
ubugeeei
added
enhancement
|
That was incredible quick 😂 |
| - name: Install Vite+ | ||
| uses: voidzero-dev/setup-vp@v1 | ||
| with: | ||
| node-version: '22' |
There was a problem hiding this comment.
node-version can be left unset, allowing vp to follow the project's node version configuration
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
use latest v6 actions/checkout@v6
| `vp release` detects likely checks from `build`, `pack`, `prepack`, `prepublishOnly`, `prepare`, and `vitePlus.release.checkScripts`. Real releases run those checks before publishing unless you pass `--no-run-checks`; dry-runs stay lightweight by default and can opt in with `--run-checks`. `--dry-run` also runs the native publisher in dry-run mode from a temporary release manifest state when the git worktree is clean. Use `--yes` for CI or other non-interactive runs, and `--version <x.y.z>` when retrying a partial publish at an exact version. | ||
|
|
||
| Real releases always create git tags after a successful publish. When every released package shares the same target version, `vp release` also creates a repository-level `v<version>` tag so GitHub Releases and repo-wide release notes can follow the same watermark. Preview-only flags such as `--skip-publish` and `--no-git-tag` are therefore limited to `--dry-run`. | ||
|
|
There was a problem hiding this comment.
This is not the right place for the release docs.
| - **`vp build`:** Build applications for production with Vite + Rolldown | ||
| - **`vp run`:** Execute monorepo tasks with caching and dependency-aware scheduling | ||
| - **`vp pack`:** Build libraries for npm publishing or standalone app binaries | ||
| - **`vp release`:** Version and publish workspace packages with native publish preflight during `--dry-run`, release checks before real publishes by default, retry-friendly exact version overrides via `--version`, optional changelog generation via `--changelog`, prerelease channels like `--preid alpha` / `beta` / `rc`, and `--projects` order respected between independent packages |
There was a problem hiding this comment.
Everything here should only be one line with 6-7 words or so.
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Before we continue discussing the code, I would like to see an rfc added to this repo + the corresponding documentation on usage. We should figure out the user experience first, and then look at whether the implementation matches that.
|
FFT for the DX @cpojer https://nx.dev/docs/features/manage-releases |
4 participants
#1169
Note
These implementations are quite comprehensive and large in scope.
Feel free to treat them as reference implementations and narrow down the scope.
Summary
This PR adds a production-oriented monorepo release workflow to
vp release.The new flow plans workspace releases from git history, computes version bumps, runs release readiness checks, performs package-manager-native publish preflight during
--dry-run, supports real publishes with safer defaults, and can generate changelogs and git tags as part of the same workflow.In addition to the core feature, this branch also includes the CI and stability fixes needed to make the new release flow buildable and green across Linux, macOS, and Windows.
What Changed
vp releaseorchestration layer for workspace packages--version--preidv<version>tag when all released packages share the same versionvite_installso package-manager-specific publish flags, provenance, and env handling are resolved in one placevp releasecapabilitiesBehavior Notes
--dry-runcan simulate publish behavior without creating durable release artifacts--skip-publishand--no-git-tagremain limited to dry-run usage--versionis intended to support retrying partial publishes at an exact target versionCI / Stabilization Included In This Branch
rolldownworkspace dependencies with current upstream namingVP_HOMEin env-related tests to avoid cache-driven flakinessValidation