chore(deps): update oxc to ^0.129.0#261
Merged
Brooooooklyn merged 3 commits intomainfrom May 6, 2026
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Member
|
@claude[agent] fix the tests failed after oxc upgrade, there must be config changes. Don't pass the test by updating the snapshot, research which config need to be changed to produce the same output |
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Member
|
@claude[agent] cargo test still fail |
…mode
In oxc 0.129.0, the TypeScript transform now generates field declarations
for constructor parameter properties (e.g., `constructor(private foo: Bar)`
generates `foo;` field declaration). This breaks JIT mode because we need
decorated fields preserved but parameter property fields removed.
Solution:
1. Before oxc transform: collect parameter property names from constructor
parameters that have accessibility modifiers, readonly, or override
2. After oxc transform: remove ONLY the field declarations that match
parameter property names AND have no decorators AND have no initializers
This approach correctly distinguishes between:
- Parameter property fields (remove): `foo;` from `constructor(private foo)`
- Decorated fields (keep): `@Input() myField;`
- Initialized fields (keep): `myField = value;`
The key insight is that JIT classes can be class expressions assigned to
variables (e.g., `let Component = class Component {...}`), not just class
declarations, so we must handle both Statement::ClassDeclaration and
Statement::VariableDeclaration with ClassExpression.
All 319 integration tests now pass.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Copilot stopped work on behalf of
Brooooooklyn due to an error
May 6, 2026 02:48
Member
|
@claude[agent] run |
Agent-Logs-Url: https://github.com/voidzero-dev/oxc-angular-compiler/sessions/8b548384-6766-4e5b-b356-b185029cf373 Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Contributor
Done in fef9c00. All 319 tests pass. |
Brooooooklyn
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.128.0→^0.129.0^0.128.0→^0.129.00.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.1290.128→0.129Release Notes
oxc-project/oxc (oxc-parser)
v0.129.0🐛 Bug Fixes
429deacnapi/parser: ExportvisitorKeysfromwasmentrypoint (#21996) (NullVoxPopuli)Configuration
📅 Schedule: (in timezone Asia/Shanghai)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.