Conversation
ahesford
left a comment
ahesford
left a comment
There was a problem hiding this comment.
Several others have attempted to package this but have eventually lost interest. I am not aware that prior concerns have been addressed. Even if they are, there are technical problems with this template; chief among these is the use of the go build style but the replacement of all of the functions it provides with custom substitutes.
| do_install() { | ||
| vbin gitea forgejo | ||
| } |
There was a problem hiding this comment.
A Void package should not arbitrarily rename the only executable provided by the project.
That said, unless and until upstream decides to differentiate its project enough to actually call the executable by its own name, I have a hard time considering this package suitable for inclusion.
There was a problem hiding this comment.
| system_accounts="forgejo" | ||
| forgejo_homedir="/var/lib/forgejo" | ||
| # For SSH access. | ||
| forgejo_shell="/bin/bash" |
There was a problem hiding this comment.
As previously noted, this should probably not be enforced; however, if there is a real reason to demand bash, the package would have to depend on bash.
4 participants
Testing the changes
New package
Local build testing