fix(core): allow ctx.rpc.sharedState access during plugin setup#195
Merged
fix(core): allow ctx.rpc.sharedState access during plugin setup#195
Conversation
Allow plugins to safely call ctx.rpc.sharedState during setup without errors. The broadcast() method now silently returns when _rpcGroup is not yet initialized, since no WebSocket clients can be connected before the WS server starts. This fixes the timing issue where shared state mutations would throw "RpcGroup is not set" during early plugin initialization. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
commit: |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow plugins to safely call
ctx.rpc.sharedStateduring their setup function without triggering timing errors. Thebroadcast()method now silently returns when_rpcGroupis not yet initialized, since no WebSocket clients can be connected before the WS server starts. This fixes the "RpcGroup is not set" error that occurred when plugins accessed shared state during setup.Linked Issues
Fixes the internal timing issue reported in plugin usage patterns.
Additional context
The fix ensures that early broadcasts are safely ignored during plugin initialization, as they are guaranteed to have zero connected clients. This allows developers to use the RPC shared state API in plugin setup functions as intended.