docs(example): map 3d markers example#765
Merged
usefulthink merged 13 commits intovisgl:mainfrom Mar 19, 2026
Merged
Conversation
andreashelms
force-pushed
the
docs/map-3d-markers-example
branch
from
689185a to
b2de09b
Compare
andreashelms
changed the title
chore: adjust location
mrMetalWood
reviewed
Feb 10, 2026
| @@ -0,0 +1,760 @@ | |||
| /* eslint-disable @typescript-eslint/no-empty-object-type */ | |||
Collaborator
There was a problem hiding this comment.
@usefulthink Do we still need this file? I think we have most if not all of this already in our general google maps types file in the lib?
Collaborator
There was a problem hiding this comment.
We do, but people copying the example wouldn't have them since they are just for development and not exported.
Added documentation for `headerContent` and `autoPanDisabled` props. Enhanced example usage with style and className support. Clarified popover behavior with the maps API and light dismiss functionality. Updated corresponding TypeScript types for better consistency.
Introduced reusable mock implementations for Google Maps 3D web components (`Marker3DElement`, `Marker3DInteractiveElement`, `PopoverElement`, and `Map3DElement`). Registered them as custom elements for test environments. Updated `Popover` and `Marker3D` tests to integrate these mocks using factory patterns for dynamic spy attachment. Added detailed README for usage and future upstream contribution plans.
Co-authored-by: Malte Modrow <malte.modrow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.