Skip to content

Fix malformed installer URLs for Windows 386 (32-bit) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bytemain merged 2 commits into from
Apr 30, 2026
Merged

Fix malformed installer URLs for Windows 386 (32-bit) #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814e408
Initial plan
Copilot Apr 30, 2026
4cd83e8
Fix Windows 386 URL generation for Python installer downloads
Copilot Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/util.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ local REQUEST_HEADERS = {

-- download source
local DOWNLOAD_SOURCE = {
MSI = PYTHON_URL .. "%s/python-%s.%s.msi",
MSI = PYTHON_URL .. "%s/python-%s%s.msi",
EXE = PYTHON_URL .. "%s/python-%s%s.exe",
SOURCE = PYTHON_URL .. "%s/Python-%s.tar",
}
Expand Down Expand Up @@ -247,12 +247,15 @@ end

function getReleaseForWindows(version)
local archType = RUNTIME.archType
if archType == "386" then
archType = ""
local exeArchSuffix = ""
local msiArchSuffix = ""
if archType ~= "386" then
exeArchSuffix = "-" .. archType
msiArchSuffix = "." .. archType
end

-- try get exe file
local url = DOWNLOAD_SOURCE.EXE:format(version, version, '-' .. archType)
local url = DOWNLOAD_SOURCE.EXE:format(version, version, exeArchSuffix)
local resp, err = http.head({
url = url,
headers = REQUEST_HEADERS
Expand All @@ -262,7 +265,7 @@ function getReleaseForWindows(version)
end

-- try get msi file
local url = DOWNLOAD_SOURCE.MSI:format(version, version, archType)
local url = DOWNLOAD_SOURCE.MSI:format(version, version, msiArchSuffix)
local resp, err = http.head({
url = url,
headers = REQUEST_HEADERS
Expand Down