fix/ESO upgrade#123
Open
day0hero wants to merge 4 commits intovalidatedpatterns:mainfrom
Open
Conversation
Contributor
day0hero
commented
Apr 17, 2026
day0hero
commented
- Repo/ESO Updates
- update to values-group-one.yaml
Collaborator
- ran patternizer against the repo to ensure that the latest goodness is
from the vp framework is applied.
- updated ESO from upstream to openshift supported
- updated values-hub to use `argoProject{,s}`
- changed namespace definition from list to dictionary. this is
currently required for the framework to support multiple versions of
an operator/service (golang-external-secrets/openshift-external-secrets)
day0hero
force-pushed
the
fix/ESO_upgrade
branch
from
d16f662 to
78350b0
Compare
mlorenzofr
requested changes
Apr 24, 2026
Collaborator
There was a problem hiding this comment.
We use this in common/scripts/vault-utils.sh
Collaborator
There was a problem hiding this comment.
Here we are removing here target vault-config-jwt
layered-zero-trust/common/Makefile
Lines 136 to 138 in 66b2766
| .PHONY: post-install | ||
| post-install: ## Post-install tasks | ||
| make load-secrets | ||
| make vault-config-jwt |
Collaborator
There was a problem hiding this comment.
In the post-install (a target not present in the Makefile-common), in addition to load-secrets, vault-config-jwt was also called. I don't believe this is part of the common VP workflow, but we need it
day0hero
added a commit
to day0hero/layered-zero-trust
that referenced
this pull request
Apr 27, 2026
- in response to validatedpatterns#123 - where we need to figure out better long term approaches for modernizing the repo structure. - this commit modifies just the values-hub.yaml and the ESO manifests within the repository to use openshift-external-secrets-operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.