dedup high-cost localization setup#11147
Conversation
Merging this PR will degrade performance by 3.46%
Performance Changes
Comparing Footnotes
|
3b85667 to
c8e6de4
Compare
|
GNU testsuite comparison: |
c8c40c8 to
90047f4
Compare
|
GNU testsuite comparison: |
|
@oech3 I think I'm missing something... Of what I see, the goal seems to be to not do a duplicate setup, but I don't understand why you set You only need Do you want |
|
I defined it outside of |
|
@lordeji was right. Maybe, I was |
|
GNU testsuite comparison: |
|
@oech3 If you confirm that the new variable has no goal to be modified externally, then I agree with you. I was waiting for PR #10911 but it seems to be inactive, if in march it did not changed, I will try to do the PR myself if I'm allowed. |
I agree with lazy loading is preffered, but requires many diff and would take many times to review... |
|
GNU testsuite comparison: |
How to block touching |
|
@oech3 Define it directly into the function I did not test it but static lifetime and local scope is not incompatible and the |
58f6dbd to
6fa46c4
Compare
|
GNU testsuite comparison: |
This comment was marked as outdated.
This comment was marked as outdated.
|
GNU testsuite comparison: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
|
Is this OK to merge? |
|
@oech3 The lazy setup would overwrite this but as I said on the other discussion, I'm not able to work until the 12th/15th of march so it may miss the 0.7.0 release and your PR is still better to have than nothing. |
This comment was marked as outdated.
This comment was marked as outdated.
8e0e138 to
20660cc
Compare
|
GNU testsuite comparison: |
Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com>
|
GNU testsuite comparison: |
|
bravo! |
mimalloc complained about localization.