ci: enable memory profiling again#10659
Conversation
|
Needs #10388 |
|
GNU testsuite comparison: |
|
Thanks! Very exited to get this used more often.
I'm not sure that this is the case, I understand that theoretically this can impact the metrics but when we were testing it the impacts to the memory profiles were not measurable. As long as the memory profiles are consistent when we test I think it should be good to go. |
Merging this PR will improve performance by ×370
Performance Changes
Comparing Footnotes
|
|
Thank you ! |
Hey! We've fixed an issue in memory profiling which caused benchmarks to have huge variance, and the results are very stable now.
I've run your benchmark CI 10 times on our fork, and there's now 0% variance across those runs: https://codspeed.io/AvalancheHQ/coreutils-1/benchmarks?q=mode%3Amemory

Let me know if you run into any other issues or if you have further questions!