fix: include platform and arch in binary cache key#10
Conversation
Cache key was `utoo-binary-{version}` which caused x86_64 binaries
to be restored on aarch64 runners, resulting in "Exec format error".
Now uses `utoo-binary-{version}-{platform}-{arch}` to ensure each
platform gets its own cached binary.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical caching bug that led to execution failures when binaries compiled for one architecture were restored on a different one. By integrating platform and architecture details into the cache key, the system now correctly isolates cached binaries, preventing cross-architecture conflicts and ensuring reliable operation across diverse environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug in the binary caching by including the platform and architecture in the cache key, preventing Exec format error across different machine architectures. The fix is applied consistently for both cache restoration and saving. I've included one suggestion to refactor the cache key generation logic to improve maintainability by avoiding code duplication.
| // Handle Utoo binary cache | ||
| if (utooCacheEnabled) { | ||
| const utooCacheKey = `utoo-binary-${resolvedVersion}`; | ||
| const utooCacheKey = `utoo-binary-${resolvedVersion}-${process.platform}-${process.arch}`; |
There was a problem hiding this comment.
This logic for generating the cache key is duplicated in src/cache-save.ts on line 17. To improve maintainability and follow the DRY (Don't Repeat Yourself) principle, consider extracting this logic into a shared utility function, for example in src/utils.ts.
For example:
// in src/utils.ts
export function getUtooCacheKey(version: string): string {
return `utoo-binary-${version}-${process.platform}-${process.arch}`;
}This would centralize the key generation, making future updates easier and less error-prone.
1 participant
Summary
utoo-binary-{version}which caused x86_64 binaries to be restored on aarch64 runners →Exec format errorutoo-binary-{version}-{platform}-{arch}to ensure each platform gets its own cached binaryaction.ts(restore) andcache-save.ts(save)Test plan
🤖 Generated with Claude Code