Skip to content

「関数」の節の演習問題1の別解を削除#934

Merged
chvmvd merged 1 commit intomainfrom
fix-functions-exercise
Mar 7, 2026
Merged

「関数」の節の演習問題1の別解を削除#934
chvmvd merged 1 commit intomainfrom
fix-functions-exercise

Conversation

@chvmvd
Copy link
Contributor

@chvmvd chvmvd commented Mar 7, 2026

次のような解答例に対して、

function max(a, b) {
  if (a > b) {
    return a;
  } else {
    return b;
  }
}

次のような別解も載せられていました。

function max(a, b) {
  if (a > b) {
    return a;
  }
  return b;
}

別解の内容はそれほど重要なことではないので、削除しました。

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an optional "note" block from the exercise 1 answer section in the "Functions" tutorial page. The note explained an alternative way to write the max function without the else keyword, which the PR author considers not essential. The corresponding sample files (max-no-else/) are also deleted.

Changes:

  • Removed the :::note block containing the alternative max implementation from docs/1-trial-session/09-functions/index.mdx.
  • Deleted the max-no-else sample directory and its files (script.js and index.html).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/1-trial-session/09-functions/index.mdx Removed the :::note block with the alternative max function (no else) and its <ViewSource> link.
docs/1-trial-session/09-functions/_samples/max-no-else/script.js Deleted sample JS file for the removed alternative solution.
docs/1-trial-session/09-functions/_samples/max-no-else/index.html Deleted sample HTML file for the removed alternative solution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@chvmvd chvmvd changed the title 「関数」の節の演習問題1の不要な説明を削除 「関数」の節の演習問題1の別解を削除 Mar 7, 2026
@chvmvd chvmvd marked this pull request as ready for review March 7, 2026 02:36
@chvmvd chvmvd merged commit ca5b21a into main Mar 7, 2026
7 checks passed
@chvmvd chvmvd deleted the fix-functions-exercise branch March 7, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants