Merged
Conversation
tknkaa
reviewed
Mar 9, 2026
src/pages/Home/index.tsx
Outdated
| </> | ||
|
|
||
| <div | ||
| className={ |
src/pages/Home/index.tsx
Outdated
| active:scale-95 | ||
| " | ||
| > | ||
| [Start Simulation] |
Contributor
There was a problem hiding this comment.
ボタンも [] もクリックできる要素であることを示していて、役割が重複しているので、[] はない方がいいかと思います。
src/pages/Home/Scene.tsx
Outdated
| import type { Planet } from "@/types/planet"; | ||
|
|
||
| export default function HomeScene() { | ||
| const planets = [earth, jupiter, mars, sun, venus]; |
Contributor
There was a problem hiding this comment.
planets は定数なので、レンダリングの度に再生成する必要はなく、コンポーネントの外に出すのがいいかと思います。
Deploying space-simulator with
|
| Latest commit: |
1b56a47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b558f219.space-simulator.pages.dev |
| Branch Preview URL: | https://createhome.space-simulator.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景に星空とランダムな天体を一つ映す構成にしました。
start simulationのボタンを押すとシミュレーション画面に移動します。