Feat/moss cli config profiles #126 by Atulsingh1155 · Pull Request #143 · usemoss/moss

Atulsingh1155 · 2026-04-10T13:36:29Z

I have read the CONTRIBUTING guide.
I have updated the documentation.
My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.

Description-

Add config profiles to moss-cli for multi-project workflows.

This PR extends auth/config behavior to support named profiles so users can switch project context without re-exporting credentials each time.

What changed-

Added profile-aware config handling with backward compatibility for legacy flat config.
Added profile selection via command option and environment variable.
Extended init command to save credentials under a named profile.
Added profile listing command.
Updated docs and examples.
Added tests for profile resolution, precedence, CLI behavior, and profile listing.

Fixes-> #126

Type of Change-

New feature (non-breaking change which adds functionality)
This change requires a documentation update

…oss#126) - add named profile storage and selection in config - support --profile and MOSS_PROFILE for credential resolution - add moss profile list command - keep backward compatibility with legacy flat config - add tests and docs for profile flows

Copilot

Pull request overview

Adds profile-aware credential/config handling to moss-cli to support switching between multiple projects without re-exporting credentials, including CLI surface area for selecting and listing profiles.

Changes:

Introduces profile-based config normalization/resolution with legacy flat-config backward compatibility.
Adds --profile support across commands (plus a new moss profile list command) and updates moss init to save credentials under a named profile.
Updates docs and adds tests for profile resolution, CLI behavior, and profile listing (also includes an interactive query mode addition).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/moss-cli/src/moss_cli/config.py	Implements profile-aware config normalization, selection, and credential resolution.
packages/moss-cli/src/moss_cli/main.py	Adds global `--profile` option and registers the new `profile` command group.
packages/moss-cli/src/moss_cli/commands/profile.py	Adds `moss profile list` command with text/JSON output.
packages/moss-cli/src/moss_cli/commands/init_cmd.py	Extends `moss init` to save credentials under a selected profile.
packages/moss-cli/src/moss_cli/commands/index.py	Plumbs profile selection into index subcommands.
packages/moss-cli/src/moss_cli/commands/doc.py	Plumbs profile selection into doc subcommands.
packages/moss-cli/src/moss_cli/commands/job.py	Plumbs profile selection into job status command.
packages/moss-cli/src/moss_cli/commands/search.py	Adds profile option usage + introduces interactive query mode and `/set` parsing.
packages/moss-cli/tests/test_profiles.py	Adds tests for profile resolution, precedence, profile listing, and CLI integration.
packages/moss-cli/tests/test_search_set_command.py	Adds unit tests for interactive `/set` command parsing.
packages/moss-cli/README.md	Documents profile usage and adds examples (including interactive query mode).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-10T13:41:31Z

+    profile: Optional[str] = typer.Option(
+        None, "--profile", envvar="MOSS_PROFILE", help="Credential profile name"
+    ),


The subcommand-level --profile options also declare envvar="MOSS_PROFILE", while the global callback already reads MOSS_PROFILE/--profile into ctx.obj["profile"]. With Click/Typer, an envvar value is applied even when the flag is not present, so this can unintentionally override an explicit global --profile (e.g. moss --profile staging index list while MOSS_PROFILE=prod). To preserve the intended precedence (CLI > env), remove envvar from the subcommand --profile options, or only overwrite ctx.obj["profile"] when the option source is the command line (e.g. via ctx.get_parameter_source).

Copilot · 2026-04-10T13:41:32Z

+    if len(parts) != 3 or parts[0] != "/set":
+        return None, "Usage: /set <alpha|top-k> <value>"
+
+    key = parts[1].lower()
+    if key not in {"alpha", "top-k", "topk"}:
+        return None, "Unknown setting. Supported: alpha, top-k"


_parse_set_command accepts topk as an alias for top-k, but both the usage string (Usage: /set <alpha|top-k> <value>) and the unknown-setting message only mention top-k. This is an inconsistent user-facing error message; either include topk in the messages or drop the alias so the help text matches actual supported inputs.

Copilot · 2026-04-10T13:41:32Z

+    interactive: bool = typer.Option(
+        False,
+        "--interactive",
+        "-i",
+        help="Start interactive query session for multiple queries against one loaded index",
+    ),


This PR is described as adding config profiles (#126), but this change set also introduces a new interactive query mode (--interactive) and supporting /set commands. That’s a significant new user-facing feature; either update the PR description/linked issue scope accordingly or split interactive mode into a separate PR to keep review and release notes aligned.

Copilot · 2026-04-10T13:41:32Z

+    profile: Optional[str] = typer.Option(
+        None, "--profile", envvar="MOSS_PROFILE", help="Credential profile name"
+    ),


The subcommand-level --profile option declares envvar="MOSS_PROFILE" while the global callback already handles MOSS_PROFILE/--profile. Because Click/Typer applies envvar values even when the flag isn't present, this can override an explicit global --profile and lead to using credentials from an unexpected profile. Prefer removing envvar from subcommand --profile options (keeping it only on the global option) or only updating ctx.obj["profile"] when the option was passed on the command line.

Copilot · 2026-04-10T13:41:33Z

+    profile: Optional[str] = typer.Option(
+        None, "--profile", envvar="MOSS_PROFILE", help="Credential profile name"
+    ),


The subcommand-level --profile option declares envvar="MOSS_PROFILE" while the global callback already handles MOSS_PROFILE/--profile. In Click/Typer, envvar values are injected even when the flag isn't present, so this can override an explicit global --profile and select the wrong credentials. Remove envvar from subcommand --profile options (or only mutate ctx.obj["profile"] when the option source is the command line).

Copilot · 2026-04-10T13:41:33Z

+    profile: str | None = typer.Option(
+        None, "--profile", envvar="MOSS_PROFILE", help="Credential profile name"
+    ),


The --profile option here declares envvar="MOSS_PROFILE" even though the global callback already reads env/flags into ctx.obj["profile"]. Since Click/Typer applies envvar defaults even when the user didn't pass --profile, this can override an explicit global --profile and run against the wrong project. Prefer removing envvar from subcommand --profile options, or only overwriting ctx.obj["profile"] when --profile was explicitly passed.

Copilot · 2026-04-10T13:41:33Z

+    profile: Optional[str] = typer.Option(
+        None,
+        "--profile",
+        envvar="MOSS_PROFILE",
+        help="Profile name to save credentials under",
+    ),


moss init defines its own --profile with envvar="MOSS_PROFILE" even though the global callback already supports --profile/MOSS_PROFILE. If a user runs moss --profile staging init while MOSS_PROFILE=prod is set, Click/Typer will still populate this command option from the envvar (since the flag wasn’t passed after init), causing init to save credentials under prod instead of the explicitly requested global profile. To keep precedence consistent, remove envvar from this command option and rely on the global callback, or accept ctx here and read the already-resolved profile from ctx.obj when the option wasn’t explicitly passed.

devin-ai-integration

Devin Review found 3 potential issues.

View 3 additional findings in Devin Review.

devin-ai-integration · 2026-04-10T13:44:46Z

+    profile: Optional[str] = typer.Option(
+        None, "--profile", envvar="MOSS_PROFILE", help="Credential profile name"
+    ),


🔴 query command's --profile envvar overrides global --profile CLI flag

The query_command in search.py:53 declares envvar="MOSS_PROFILE" on its own --profile option, while the global callback in main.py:50 also reads from the same envvar. This is inconsistent with all other subcommands (index, doc, job, init) which do not set envvar on their subcommand-level --profile.

When MOSS_PROFILE=staging is set and the user runs moss --profile prod query my-index "test", the global callback correctly resolves profile="prod" (explicit flag overrides envvar) and sets ctx.obj["profile"] = "prod". However, the query command's own profile parameter falls back to the envvar (since no --profile was passed after query), receiving "staging". The if profile: guard at line 68 then overwrites ctx.obj["profile"] back to "staging", causing the wrong credentials to be used. The test test_global_profile_overrides_environment at packages/moss-cli/tests/test_profiles.py:176 validates this global-override behavior for index list but not for query, so the bug goes uncaught.

Was this helpful? React with 👍 or 👎 to provide feedback.

- preserve explicit global profile precedence by removing subcommand envvar defaults - make init honor the resolved global profile from ctx.obj - remove unrelated interactive query additions from this PR - clean up docs and tests to match the final scope

…ss#126) - stop set_profile_credentials from always switching active_profile - keep active profile unless missing or invalid - add tests for preserve/initialize active profile behavior

Atulsingh1155 · 2026-04-10T14:15:51Z

@yatharthk2 please check this PR ..if found any issuee then please tell

Atulsingh1155 · 2026-04-10T14:16:43Z

Atulsingh1155 · 2026-04-14T16:26:11Z

@yatharthk2 please review this PR

- add moss profile delete with confirmation and JSON output - preserve or safely recover the active profile when deleting - document the delete command and add regression tests

Atulsingh1155 · 2026-04-18T08:34:39Z

@yatharthk2 please review the pr

Atulsingh1155 added 6 commits April 7, 2026 22:39

feat(moss-cli): add interactive mode for query (usemoss#127)

d9da747

fix(moss-cli): resolve interactive query review comments (usemoss#127)

58c0cd8

fix(moss-cli): handle /set parsing and interactive stdin flow

84a270a

fix(moss-cli): improve interactive stdin and query error handling

804dde5

fix(moss-cli): clarify interactive behavior with redirected stdin

0e2e047

Copilot AI review requested due to automatic review settings April 10, 2026 13:36

Atulsingh1155 requested review from CoderOMaster, HarshaNalluru, r4ghu and yatharthk2 as code owners April 10, 2026 13:36

Copilot started reviewing on behalf of Atulsingh1155 April 10, 2026 13:37 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

devin-ai-integration bot reviewed Apr 10, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

fix(moss-cli): preserve active profile when saving credentials (usemo…

4f1a10a

…ss#126) - stop set_profile_credentials from always switching active_profile - keep active profile unless missing or invalid - add tests for preserve/initialize active profile behavior

yatharthk2 requested changes Apr 16, 2026

View reviewed changes

Comment thread packages/moss-cli/README.md

feat(moss-cli): add profile deletion support (usemoss#126)

49fcd57

- add moss profile delete with confirmation and JSON output - preserve or safely recover the active profile when deleting - document the delete command and add regression tests

Conversation

Atulsingh1155 commented Apr 10, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Atulsingh1155 commented Apr 10, 2026

Uh oh!

Atulsingh1155 commented Apr 10, 2026

Uh oh!

Atulsingh1155 commented Apr 14, 2026

Uh oh!

Uh oh!

Atulsingh1155 commented Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Atulsingh1155 commented Apr 10, 2026 •

edited by devin-ai-integration bot

Loading

devin-ai-integration bot Apr 10, 2026 •

edited

Loading