ci: add contributor check to validate-files-and-commits#687
Open
Anshumancanrock wants to merge 2 commits into
Open
ci: add contributor check to validate-files-and-commits#687Anshumancanrock wants to merge 2 commits into
Anshumancanrock wants to merge 2 commits into
Conversation
✅ Deploy Preview for urunc canceled.
|
c27b3d0 to
b797398
Compare
Fixes: urunc-dev#683 Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
50a1c79 to
bf35f9e
Compare
Author
|
Hi @cmainas, please take a look at this PR and let me know your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a PR author isn't listed in
.github/contributors.yaml, thenubificus/git-trailersaction fails at merge time after the review is already done. This happens in bothadd-git-trailers.ymlandpr-merge.yml.This PR adds a
check-contributorjob tovalidate-files-and-commits.ymlthat catches missing contributors early during CI.The job normalizes the PR author's username using the same
sedlogic asnubificus/git-trailers(strips[bot]suffix,app/prefix), does a primary lookup by YAML key, and falls back to anamefield search for bot accounts. If the author isn't found, it fails with a message showing exactly what entry to add.Related issues
How was this tested?
Tested the grep matching logic locally against the current
contributors.yaml:ananos,johnp41) : matched correctlymgkeka-nbfc) : matched correctlyDionisiaK4) : matched correctlydependabot[bot]) : matched via bot fallbackananovsananos) : correctly rejectedLLM usage
N/a
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).