Skip to content

fix(create): report actual exit status when nsenter exits unsuccessfully #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdryaan wants to merge 2 commits into
base: main-pr676
Choose a base branch
from
Open

fix(create): report actual exit status when nsenter exits unsuccessfully #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
558f8c4
fix(create): report actual exit status when nsenter exits unsuccessfully
mdryaan May 14, 2026
4dfc0e8
chore(contributors): add mdryaan
mdryaan May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/contributors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,6 @@ users:
parthdagia05:
name: Parth Dagia
email: parth.24bcs10414@sst.scaler.com
mdryaan:
name: Md Raiyan
email: alikhurshid842001@gmail.com
2 changes: 1 addition & 1 deletion cmd/urunc/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ func handleNsenterRet(initSock *os.File, reexec *exec.Cmd) (int, error) {
}
if !status.Success() {
_ = reexec.Wait()
return -1, fmt.Errorf("nsenter unsuccessful exit: %w", err)
return -1, fmt.Errorf("nsenter unsuccessful exit: %d", status.ExitCode())
}

return pid.Stage2Pid, nil
Expand Down