fix: remove fallback 500 status for client errors#496
Open
fix: remove fallback 500 status for client errors#496
500 status for client errors#496Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
===========================================
+ Coverage 56.86% 69.82% +12.96%
===========================================
Files 16 17 +1
Lines 728 527 -201
Branches 113 137 +24
===========================================
- Hits 414 368 -46
+ Misses 303 148 -155
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #495
This PR removes the fallback
500status for client errors.❗ Noted that this might be a breaking change for users who rely on this fallback behavior.
When
500is included in theretryStatusCodes(default):Before and after are the same.
When
500is excluded (manually):Before: won't retry
After: will retry