Skip to content

Add tf shape enum#4130

Merged
timothy-nunn merged 5 commits intomainfrom
add_tf_shape_enum
Mar 25, 2026
Merged

Add tf shape enum#4130
timothy-nunn merged 5 commits intomainfrom
add_tf_shape_enum

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from a team as a code owner March 19, 2026 10:33
@chris-ashe chris-ashe added TF Coil Toroidal field coil Refactor labels Mar 19, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.63%. Comparing base (12afd93) to head (6aa33d0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
process/models/tfcoil/base.py 53.84% 6 Missing ⚠️
process/core/init.py 60.00% 2 Missing ⚠️
process/core/io/plot_proc.py 50.00% 1 Missing ⚠️
process/models/pfcoil.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4130      +/-   ##
==========================================
- Coverage   47.91%   47.63%   -0.29%     
==========================================
  Files         142      142              
  Lines       29923    29970      +47     
==========================================
- Hits        14338    14276      -62     
- Misses      15585    15694     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe marked this pull request as draft March 20, 2026 09:10
@chris-ashe chris-ashe marked this pull request as ready for review March 24, 2026 09:09
@timothy-nunn timothy-nunn self-assigned this Mar 24, 2026
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to replace all uses of testing (e.g. if i == 1) or setting using bare constants to be replaced. Here are some other locations this occurs:

  • plot_proc.py
  • build.py
  • pfcoil.py
  • tfcoil/base.py
  • test_build.py

@timothy-nunn timothy-nunn changed the title Add tf shape enum Add tf shape enum Mar 25, 2026
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, I may just be being silly

@timothy-nunn timothy-nunn merged commit 87727f9 into main Mar 25, 2026
10 checks passed
@timothy-nunn timothy-nunn deleted the add_tf_shape_enum branch March 25, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants