Skip to content

Use Stub Parser 3.28.1#7710

Merged
mernst merged 8 commits into
typetools:masterfrom
mernst:updating-javaparser-parent-3.28.1
May 14, 2026
Merged

Use Stub Parser 3.28.1#7710
mernst merged 8 commits into
typetools:masterfrom
mernst:updating-javaparser-parent-3.28.1

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 9, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b1dbc562-60c2-4485-87e3-b38e58e96a10

📥 Commits

Reviewing files that changed from the base of the PR and between 72a3bcf and 0cb8a4f.

📒 Files selected for processing (2)
  • .circleci/config.yml
  • checker/bin-devel/test-misc.sh

📝 Walkthrough

Walkthrough

This PR updates the stubparser library from version 3.28.0 to 3.28.1 in the Gradle version catalog. It adds a new ci-info run step to the CircleCI misc_job macro and corresponding jobs (misc_jdk21, misc_jdk25, misc_jdk26) that fetches plume scripts and runs ci-info --debug before the existing test-misc.sh step. The PR also refactors test-misc.sh to replace a single status variable with a failures array, enabling collection and reporting of specific failure messages from Javadoc-related tasks.

Possibly related PRs

  • typetools/checker-framework#7662: Adds ci-info invocation to CircleCI workflows, implementing the same ./checker/bin-devel/.plume-scripts/ci-info execution pattern now being extended to misc_jdk jobs.
  • typetools/checker-framework#7381: Introduces the Gradle version catalog including the stubparser entry that this PR now updates to a newer version.
  • typetools/checker-framework#7600: Introduces the misc_jdk26 job that this PR now augments with the ci-info step and matches the JDK 26 testing pattern.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@checker/bin-devel/test-misc.sh`:
- Around line 49-52: The script currently masks Gradle failures by using "||
true" when running the requireJavadoc and javadocDoclintAll tasks, so replace
that pattern with explicit exit-code checks: run ./gradlew requireJavadoc
--warning-mode=all > /tmp/warnings-requireJavadoc.txt 2>&1 and capture its exit
code ($?), call "$PLUME_SCRIPTS"/ci-lint-diff on the output as before, and if
the gradle exit code is non-zero append a descriptive entry to the failures
array (e.g., failures+=("gradlew requireJavadoc failed (exit $code)" )). Do the
same for ./gradlew javadocDoclintAll (use /tmp/warnings-javadocDoclintAll.txt)
so both gradle failures and ci-lint-diff failures are recorded in failures
instead of being ignored; keep the same temp-file names and the existing
ci-lint-diff invocation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c5f3c237-ab15-4021-ba3f-767869c82b03

📥 Commits

Reviewing files that changed from the base of the PR and between d8427e8 and 5c09a13.

📒 Files selected for processing (1)
  • checker/bin-devel/test-misc.sh

Comment thread checker/bin-devel/test-misc.sh
@mernst mernst merged commit 8eafa3b into typetools:master May 14, 2026
34 checks passed
@mernst mernst deleted the updating-javaparser-parent-3.28.1 branch May 14, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant