fix(api_call): Handle JsonException on success response path#117
Merged
tharropoulos merged 2 commits intotypesense:masterfrom Mar 9, 2026
Merged
Conversation
When a 2xx response contains invalid JSON and asJson is true, json_decode with JSON_THROW_ON_ERROR throws an uncaught JsonException. Wrap the call in a try/catch and re-throw as TypesenseClientError with the HTTP status code and a truncated response body for debugging. Fixes typesense#52
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
PR #111 fixed uncaught
JsonExceptionon the error response path (non-2xx), but the success response path (2xx withasJson=true) still throws an uncaughtJsonExceptionwhen the server returns invalid JSON with a 2xx status code.Wrap the success-path
json_decodein a try/catch and re-throw asTypesenseClientErrorwith the HTTP status code and a truncated response body for debugging.Fixes #52
PR Checklist