feature: add $form-select-focus-bg variable for focused select inputs#42050
feature: add $form-select-focus-bg variable for focused select inputs#42050claytonlin1110 wants to merge 1 commit intotwbs:mainfrom
Conversation
|
Can someone review this? |
|
Right now, we’re focusing on |
|
@julien-deramond When could it be ready? can i change destination branch from 'main ' to 'v6-dev'? |
|
There is no need to change the target branch. We will review the PR as is and cherry-pick the commit to |
|
Can you just get this Pr reviewred and merge to v6-dev? |
|
This is a terribly bad idea, and makes zero sense from a UI/UX perspective. 😑 Why would you want to tint the background (and in the primary color too?!), therefore to reduce the visibility of the content typed in, when the input is focused? Boostrap already a focus state in the form of an outline for inputs. Generally, when using tinted (dark) backgrounds, it's when the Also, in Bootstrap, the background of inputs are grayed out when in a disabled state. So if anyone decides to go with a gray/zinc/dark/black theme, tinting on focus will make the inputs look like they're disabled. I'd love to see an example where this makes sense. |
|
This is no longer needed in v6-dev for two reasons: 1) we're not using Sass variables for component tokens, and 2) we're still not making |
Description
Adds the SASS variable
$form-select-focus-bgto control the background color of focused select inputs.Closes #42006
Motivation
As
$input-focus-bgcan tint the background of focused inputs, it makes sense to have equivalent control for focused select inputs. This allows users to customize or tint the focus state of form selects independently or in line with inputs.Changes
scss/_variables.scss: Added$form-select-focus-bg(defaults to$input-focus-bg) alongside other form-select focus variablesscss/forms/_form-select.scss: Setbackground-color: $form-select-focus-bgon:focusstateUsage
// Customize focused select background
$form-select-focus-bg: tint-color($primary, 95%);
@import "bootstrap/scss/bootstrap";