Wire up progress after re-launch using URLSession delegate#228
Open
samsonjs wants to merge 1 commit into
Open
Conversation
Rather than using KVO on the task to monitor progress, we now use URLSession's delegate method which can survive a relaunch. There's no way to reconstruct the upload task so this is the only durable method. Adds some tests and cleans up the progress callback registry. Disclosure: assisted by Claude Code and Codex Closes tus#227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using KVO on the task to monitor progress, we now use URLSession's delegate method which can survive a relaunch. There's no way to reconstruct the upload task so this is the only durable method. KVO observation is kept as a compatibility fallback for the deprecated
TUSClient.initthat accepts a URLSession.Adds some tests and cleans up the progress callback registry. More can be cleaned up after
TUSClient.init(session:)is removed.Disclosure: assisted by Claude Code and Codex
Closes #227