Add same-net trace combining phase#303
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Format check is green after e8b0679. Current PR checks are all passing: test, type-check, format-check, and Vercel. |
|
Added durable before/after visual proof for the #34 surface from the SVG snapshots:
The files compare |
b8319c7 to
df7ea59
Compare
|
Added a small extra coverage pass after the visual proof: the focused solver suite now also checks vertical same-net snapping and verifies that the merge-distance / minimum-overlap thresholds leave non-qualifying same-net segments unchanged. Verification after the update:
|
|
Quick review-ready status update for maintainers: PR #303 is still green across test, type-check, format-check, and Vercel after the extra solver coverage. The branch has focused proof for both claimed surfaces (#29 and #34), including before/after visual assets and the demo video linked above. Happy to trim or tune the merge thresholds if you want a narrower acceptance window. |
/claim #34
/claim #29
Summary
example34passes with this pipeline phaseVerification
npx --yes bun test tests/solvers/SameNetTraceCombiningSolver/SameNetTraceCombiningSolver.test.tsnpx --yes bun test tests/examples/example29.test.tsnpx --yes bun test tests/examples/example30.test.tsnpx --yes bun test tests/examples/example34.test.tsnpx --yes bun run buildnpx --yes biome format lib/solvers/SameNetTraceCombiningSolver/SameNetTraceCombiningSolver.ts lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts tests/solvers/SameNetTraceCombiningSolver/SameNetTraceCombiningSolver.test.tsgit diff --checkNote:
bun run format:checkcurrently reports repo-wide CRLF formatting drift in many pre-existing files, so I verified formatting on the changed files directly.