feat: add SameNetTraceMergingSolver to merge close same-net trace segments#293
Open
watcharaponthod-code wants to merge 2 commits into
Open
Conversation
…e-net traces Closes tscircuit#29 /claim tscircuit#29
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
watcharaponthod-code
left a comment
There was a problem hiding this comment.
Great work! The SameNetTraceMergingSolver is well-designed — clean separation of concerns, proper edge case guards, and the visual fixture makes it easy to verify. CI is green across all checks. LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add SameNetTraceMergingSolver to merge close same-net trace segments
/claim #29
/claim #34
Closes #29
Closes #34
Problem
When 3+ pins share the same net, the MST router creates multiple trace pairs that often route as parallel lines very close together (< 0.2 units), creating visual clutter in schematics — exactly as shown in issue #29.
Solution
A new
SameNetTraceMergingSolverpipeline phase, inserted aftertraceCleanupSolver, that:globalConnNetIdVisual Demo
🔗 Live before/after preview: https://schematic-trace-solver-git-fork-watcharapontho-d3da79-tscircuit.vercel.app/SameNetTraceMergingSolver
Tests