Skip to content

feat: merge same-net trace lines that are close together at same X or Y#282

Open
sagarshuklaa wants to merge 2 commits into
tscircuit:mainfrom
sagarshuklaa:main
Open

feat: merge same-net trace lines that are close together at same X or Y#282
sagarshuklaa wants to merge 2 commits into
tscircuit:mainfrom
sagarshuklaa:main

Conversation

@sagarshuklaa
Copy link
Copy Markdown

@sagarshuklaa sagarshuklaa commented May 6, 2026 •
edited
Loading

/claim #34

Fixes #34

What this PR does

  • Adds a new mergeSameNetCloseTraces function in TraceCleanupSolver
  • Detects horizontal trace segments on the same net with nearly identical Y coordinates and merges them into one
  • Detects vertical trace segments on the same net with nearly identical X coordinates and merges them into one
  • Called as the final step in the TraceCleanupSolver pipeline
  • All existing tests pass (example03 timeout was pre-existing)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview, Comment May 7, 2026 3:12am

Request Review

@algora-pbc algora-pbc Bot mentioned this pull request May 6, 2026
Open
@sagarshuklaa
Copy link
Copy Markdown
Author

sagarshuklaa commented May 7, 2026

All checks are now passing ✅

  • Fixed TypeScript type error (using dcConnNetId for net comparison)
  • Fixed formatting
  • All 4 CI checks green

Ready for review! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge same-net trace lines that are close together (make at the same Y or same X)

1 participant

@sagarshuklaa