Check netlabel<>netlabel collisions and prioritize port-only labels#281
Open
64johnlee wants to merge 1 commit into
Open
Check netlabel<>netlabel collisions and prioritize port-only labels#28164johnlee wants to merge 1 commit into
64johnlee wants to merge 1 commit into
Conversation
- Add netLabelCollisions tracking array to record collisions without failing - Sort overlappingSameNetTraceGroups: port-only labels first - Add checkNetLabelCollisions() to detect overlaps between different nets - Add netLabelsOverlap() helper using getRectBounds - Fixes tscircuit#45
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45 - Check netlabel<>netlabel collisions, place "port only" net labels first
Changes:
Tests:
Closes #45