fix(config): replace external.ip=null with empty string#86
Open
vividctrlalt wants to merge 1 commit intotronprotocol:mainfrom
Open
fix(config): replace external.ip=null with empty string#86vividctrlalt wants to merge 1 commit intotronprotocol:mainfrom
vividctrlalt wants to merge 1 commit intotronprotocol:mainfrom
Conversation
HOCON null values cannot be bound by ConfigBeanFactory to String fields. Use empty string instead, which has the same effect (triggers the automatic IP detection fallback in java-tron). Related: tronprotocol/java-tron#6615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
external.ip = nullwithexternal.ip = ""in 3 test config files.Why
HOCON
nullvalues cannot be bound byConfigBeanFactorytoStringfields.Using empty string instead has the same runtime effect — it triggers the automatic
IP detection fallback in java-tron. This avoids
ConfigException$Nullwhenjava-tron adopts
ConfigBeanFactoryfor config binding.Changed files
config-localtest.confconfig-test-dbbackup.confconfig-test-index.confRelated: tronprotocol/java-tron#6615