feat(jsonrpc): restrict batch size, response size, address size and request timeout#6645
Closed
317787106 wants to merge 3 commits intotronprotocol:developfrom
Closed
feat(jsonrpc): restrict batch size, response size, address size and request timeout#6645317787106 wants to merge 3 commits intotronprotocol:developfrom
317787106 wants to merge 3 commits intotronprotocol:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node.jsonrpc.maxBatchSizeto limit JSON-RPC batch request size, preventing resource exhaustion from oversized batch callsnode.jsonrpc.maxResponseBodySizeto cap response body size, mitigating potential DoS via large response generationnode.jsonrpc.maxAddressSizeto restrict the number of addresses in a single requestnode.jsonrpc.maxRequestTimeoutto enforce a timeout on JSON-RPC request processingMotivation
These limits protect the JSON-RPC API surface from abuse patterns including:
Configuration
New fields in
config.confundernode.jsonrpc:Test plan
maxBatchSizeare rejected with appropriate errormaxResponseBodySizereturnJsonRpcResponseTooLargeExceptionmaxAddressSizeare rejectedmaxRequestTimeoutare terminated🤖 Generated with Claude Code