feat(protocol): add protoLint check for enum validation#6631
feat(protocol): add protoLint check for enum validation#66310xbigapple wants to merge 4 commits intotronprotocol:developfrom
Conversation
|
Nice work — this solves a real problem and the implementation is solid. A few suggestions: Should fix:
Worth considering:
|
|
@vividctrlalt Thanks for the detailed review! I really appreciate the feedback and the time you took to look into this. I've considered the points you raised and would like to share my thoughts for discussion: Regarding the "Should fix" items:
Regarding the "Worth considering" items:
I hope these explanations clarify the design choices! Let me know what you think about these points, and I'm happy to discuss further if you feel strongly about any of them. |
|
Thanks for the thorough responses — your points on #2 (stderr default passthrough) and #3 (script-as-input covers version changes) are correct. I agree with all your explanations. Two suggestions going forward:
|
What does this PR do?
UNKNOWN_prefix for Enum index 0 to ensure JSON serialization compatibility.check.dependsOn protoLint) which run automatically during CI and local full builds. Also support run manually with./gradlew :protocol:protoLintor./gradlew :protocol:check.Why are these changes required?
close #6515
This PR has been tested by:
Follow up
Extra details